fix(mcp): clear backendPromise in onClose to allow backend recreation#40019
Closed
mlugo-apx wants to merge 2 commits intomicrosoft:mainfrom
Closed
fix(mcp): clear backendPromise in onClose to allow backend recreation#40019mlugo-apx wants to merge 2 commits intomicrosoft:mainfrom
mlugo-apx wants to merge 2 commits intomicrosoft:mainfrom
Conversation
When onClose fires, the handler was disposing the backend but not clearing backendPromise. This caused subsequent tool calls to await the stale promise and receive a disposed backend, resulting in 'Not connected' errors. The fix clears backendPromise before disposing, allowing the next tool call to create a fresh backend. Fixes microsoft#40018
- Add browserConnectionEnded flag to track unexpected disconnections - Prepend recovery notice to tool result when reconnecting between calls - Use wording 'state might be lost' per maintainer feedback - Only show notice for disconnects between tool calls, not during
Member
|
Unclear what you are testing without a test. This onClose is from server.onClose, server is gone. backendPromise is in the scope of creating that server, irrelevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40018
When
onClosefires, the handler was disposing the backend but not clearingbackendPromise. This caused subsequent tool calls to await the stale promise and receive a disposed backend, resulting in "Not connected" errors.Changes
Before:
After:
Testing